redpanda
redpanda copied to clipboard
redpanda-data
config: update bindings when properties are reset
Previously we just set the value without notifying bindings. This led to ignoring property value updates when the property was reset to its default value as a result of a patch_cluster_config request with non-empty "remove" section.
Backports Required
- [ ] none - not a bug fix
- [ ] none - this is a backport
- [ ] none - issue does not exist in previous branches
- [ ] none - papercut/not impactful enough to backport
- [x] v23.3.x
- [x] v23.2.x
- [x] v23.1.x
Release Notes
Bug Fixes
- Fix a bug that resulted in Redpanda ignoring until the next restart config values that were reset to their defaults.
new failures in https://buildkite.com/redpanda/redpanda/builds/45036#018da714-22dd-4c1a-8a14-8548725ac589:
"rptest.tests.cluster_config_test.ClusterConfigTest.test_rpk_import_sparse.all=False"
new failures in https://buildkite.com/redpanda/redpanda/builds/45036#018da73b-a118-4070-98b6-365a9eb0ef66:
"rptest.tests.cluster_config_test.ClusterConfigTest.test_rpk_import_sparse.all=True"
new failures in https://buildkite.com/redpanda/redpanda/builds/45036#018da73b-a115-4f6c-ae63-d398a3707264:
"rptest.tests.cluster_config_test.ClusterConfigTest.test_rpk_import_sparse.all=False"
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45036#018da73b-a115-4f6c-ae63-d398a3707264
Failed to create a backport PR to v23.2.x branch. I tried:
git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-16504-v23.2.x-367 remotes/upstream/v23.2.x
git cherry-pick -x bde7db0e8185e0e9bd6e20783e065291f4c70525 30309ea5fb2c2521e6d5e42378ead610037d990c bb6e9b4ddc3f5c43cbd1c459143824f96f96a675 d58fe3db18ab7f13d531ffa11d1a836e8bb72db2 741158695070159595348cc766bfe51861d4166d 63eb446a94a5df3d7da64abd6e8f6e7bd26bb133
Failed to create a backport PR to v23.1.x branch. I tried:
git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-16504-v23.1.x-331 remotes/upstream/v23.1.x
git cherry-pick -x bde7db0e8185e0e9bd6e20783e065291f4c70525 30309ea5fb2c2521e6d5e42378ead610037d990c bb6e9b4ddc3f5c43cbd1c459143824f96f96a675 d58fe3db18ab7f13d531ffa11d1a836e8bb72db2 741158695070159595348cc766bfe51861d4166d 63eb446a94a5df3d7da64abd6e8f6e7bd26bb133