redpanda-operator icon indicating copy to clipboard operation
redpanda-operator copied to clipboard

Setting `retention.ms` in `additionalConfig` doesn't work

Open vuldin opened this issue 1 year ago • 1 comments

Applying the following doesn't give an error, but retention.ms remains at 7 days as opposed to the desired 1 day:

apiVersion: cluster.redpanda.com/v1alpha1
kind: Topic
metadata:
  name: healthcheck
spec:
  kafkaApiSpec:
    brokers: 
      - "redpanda-0.redpanda.hypeboards.svc.cluster.local:9093"
    tls:
      caCertSecretRef:
        name: "redpanda-default-cert"
        key: "ca.crt"
  additionalConfig:
    retention.ms: "86400000"

The following throws an error:

apiVersion: cluster.redpanda.com/v1alpha1
kind: Topic
metadata:
  name: healthcheck
spec:
  kafkaApiSpec:
    brokers: 
      - "redpanda-0.redpanda.hypeboards.svc.cluster.local:9093"
    tls:
      caCertSecretRef:
        name: "redpanda-default-cert"
        key: "ca.crt"
  additionalConfig:
    retention.ms: 86400000

Error:

Error: UPGRADE FAILED: cannot patch "healthcheck" with kind Topic: [Topic.cluster.redpanda.com](http://topic.cluster.redpanda.com/) "healthcheck" is invalid: [spec.additionalConfig.retention.ms](http://spec.additionalconfig.retention.ms/): Invalid value: "integer": [spec.additionalConfig.retention.ms](http://spec.additionalconfig.retention.ms/) in body must be of type string: "integer"

I would expect the first attempt to work since additionalConfig requires all input to be a string.

See this community slack post (and thread) for details.

JIRA Link: K8S-195

vuldin avatar Mar 06 '24 15:03 vuldin

:wave: Was looking to pick up an issue. When I try and replicate this, I do see an error message:

# * spec.additionalConfig.retention.ms: Invalid value: "integer": spec.additionalConfig.retention.ms in body must be of type string: "integer"

Should this issue be closed as fixed? Or is the described behavior still incorrect?

JayKayy avatar May 30 '24 19:05 JayKayy