console icon indicating copy to clipboard operation
console copied to clipboard

Deserialize messages in smile format

Open rrva opened this issue 2 years ago • 3 comments

Autodetect and deserialize messages in smile format

https://github.com/FasterXML/smile-format-specification

rrva avatar May 26 '22 21:05 rrva

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 26 '22 21:05 CLAassistant

@weeco - let's think how to expose this, maybe as a plugin framework? (like RPK plugins?) - so that way people can plugin custom serializations.

emaxerrno avatar May 27 '22 19:05 emaxerrno

@senior7515 oh please noo this delays this even further, exactly what https://github.com/provectus/kafka-ui chose to answer when I made a PR there ;)

The existing deserialization support is non-pluggable and until that gets rewritten into plugins, I would have to run a fork of kowl which is tedious to rebase when fixes arrive... So if plugins are a while away I argue for this to be included in the meantime, it is not hard to extract once that support is there. If you look at the patch it is small and adds just one other case to the existing deserialization cases. Other than that I fully agree with the architectural argument of having plugins.

rrva avatar May 28 '22 14:05 rrva

@weeco please reconsider this... has something happened on the plugin architecture which make this easy to add (how?) or could it be merged as-is?

rrva avatar Oct 03 '22 18:10 rrva

Hey @rrva , we haven't worked on the plugin architecture yet.

However, I think it won't hurt to add this by default, even though I'd like to preserve the right to remove it (or put behind a feature flag / plugin) in an upcoming version, if this conflicts with the other deserialization methods. I think this format is rarely used in the Kafka community and is an ideal usecase for such a plugin.

weeco avatar Oct 05 '22 10:10 weeco

thanks a lot! I understand your reservations. I'll try it and report back if there are any issues with it. I do not see it hurt the existing deserializer path a lot for performance etc.

rrva avatar Oct 05 '22 19:10 rrva