connect icon indicating copy to clipboard operation
connect copied to clipboard

Add MongoDB processor find-all operation

Open webfrank opened this issue 2 years ago • 4 comments

Hi, I've added find-all operation to MongoDB processor. Cannot use bson.MarshalExtJSON because for an array it returns the Error: WriteArray can only write a Array while positioned on a Element or Value but is positioned on a TopLevel

webfrank avatar Jun 20 '23 15:06 webfrank

Looks like we'll need to work around the array issue by iterating the returned BSON objects into a []json.RawMessage and then marshal that into the final binary format. We also ideally need at least one unit test. I can do those two on my side when I merge but you need to add the sign off: https://github.com/benthosdev/benthos/pull/1969/checks?check_run_id=14410191847

Jeffail avatar Jun 27 '23 07:06 Jeffail

Hi, don't know if I've done it correctly.

webfrank avatar Jun 28 '23 12:06 webfrank

Running git commit --amend -s would've done it, it just requires Signed-off-by: foo <bar>, looks like the PR got blown up from a merge (reporting 41 files changed).

Jeffail avatar Jul 02 '23 07:07 Jeffail

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

:white_check_mark: Jeffail
:x: Francesco Boscarino
:x: rasnes


Francesco Boscarino seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 27 '25 14:01 CLAassistant