HomeKey-ESP32 icon indicating copy to clipboard operation
HomeKey-ESP32 copied to clipboard
verified publisher icon rednblkx

Added image preview for HomeKey Card Finish in Misc configuration page on HomeKey Card Finish click

Open adukale opened this issue 1 year ago • 2 comments

This pull request adds image preview for HomeKey Card Finish in Misc configuration page on HomeKey Card Finish click.

gif showing the UI: hk-finish-preview

If you accept this commit then we can remove the images from littlefs and add raw links of images in code, which will free up the space. Let me know.

adukale avatar Aug 19 '24 20:08 adukale

Hi! Appreciate the PR 😀

Got some thoughts on this:

  • The images are taking up too much space and i do not intend to embed external links into the webui.

  • All images are too high-res for this purpose and hence have a lot of redundant data, resizing them will help greatly, as an example, resizing hk-finish-0.webp to 256x162 is plenty enough and brings it down from 7.0 KiB to 710 B

hk-finish-0_resized

Right now am working on reorganizing and refreshing the design of the webui, once done i'll rebase the PR and merge it in along with the resized the images

rednblkx avatar Aug 21 '24 15:08 rednblkx

Great. Let me know if you need any help. Happy to help.

adukale avatar Aug 21 '24 16:08 adukale