django-async-orm icon indicating copy to clipboard operation
django-async-orm copied to clipboard

Published 20 hours ago • verified publisher icon rednaks

Count feature, related test and import optimisation

Open rkisdp opened this issue 2 years ago • 8 comments

Hi, @rednaks,

I have added the count feature and test for the same, and with that, I have also changed some other tests accordingly and removed unused imports from the file. Please have a look and give your feedback.

rkisdp avatar Jul 01 '22 11:07 rkisdp

Hi, @rednaks, Can you please review the PR? and please let me know if you think I have made any mistake.

rkisdp avatar Jul 03 '22 06:07 rkisdp

Thank you, looks good for me, can you just update the README file for the count and none ?

Thanks !

rednaks avatar Jul 03 '22 10:07 rednaks

Sure! Can I add some tests for some other features which are active but the test isn't available?

rkisdp avatar Jul 03 '22 18:07 rkisdp

Hi, @rednaks, I have updated the README file and added some tests also. Please review this and let me know if you want me to add something else.

rkisdp avatar Jul 03 '22 19:07 rkisdp

Hi, @rednaks, Can you please review the changes and let me know if you want any more here? I want to contribute more.

rkisdp avatar Jul 10 '22 08:07 rkisdp

Thank you for your PR, but I don't know why you removed so many tests ... please revert them and make the changes requested in the comments.

Thank you

rednaks avatar Jul 12 '22 08:07 rednaks

Hi, @rednaks, thanks for your valuable feedback. I have changed the test file according to your comments but there is no change in the readme file. Both the features are available in the module that's why I removed them from the readme file. Thanks again for your valuable feedback.

rkisdp avatar Jul 12 '22 13:07 rkisdp

Hi, @rednaks did you check this? any feedback?

rkisdp avatar Jul 24 '22 08:07 rkisdp