otomi-core icon indicating copy to clipboard operation
otomi-core copied to clipboard

Helm chart repository previous versions

Open mojtabaimani opened this issue 4 years ago • 5 comments

Describe the bug: When making a new otomi chart release, it will override the index.yaml file of the chart repository and doesn't keep the previous versions. But it should just append the new version to the current index.yaml.

To Reproduce Steps to reproduce the behavior:

  1. change the version of the chart in chart/otomi/chart.yaml and push to master
  2. go to branch: gh-pages and look at index.yaml file. You will see only the latest release and not the older ones.

Expected behavior: (a clear and concise description of what you expected to happen) It should update the index.yaml file with the new release and not creating and replacing a new file.

mojtabaimani avatar Aug 02 '21 14:08 mojtabaimani

related link: https://helm.sh/docs/howto/chart_repository_sync_example/#generate-an-updated-indexyaml

mojtabaimani avatar Aug 05 '21 09:08 mojtabaimani

@mojtabaimani please create a story out of this and it in backlog

dominikatrela avatar Aug 24 '21 08:08 dominikatrela

@svatwork I removed your link to a chart releaser action issue, as that was unrelated (feature request to overwrite existing release, which should never happen imo).

Morriz avatar Sep 06 '21 09:09 Morriz

I thought we were using that action, but anyway, I sent a wrong issue, I actually meant this one: https://github.com/helm/chart-releaser-action/issues/70 (ie., chart releases get appended not overwritten).

Edit:

I now see we use that chart action:

      - if: '${{ steps.prereq.outputs.has_changes }}'
        name: Create and publish otomi chart release
        id: chart_release
        uses: helm/[email protected]
        with:
          charts_dir: chart
          charts_repo_url: https://otomi.io/charts/
        env:
          CR_TOKEN: '${{ secrets.GITHUB_TOKEN }}'

My point is that the feature to append instead of overwrite is in progress.

0-sv avatar Sep 10 '21 13:09 0-sv

@mojtabaimani please create a story out of this and it in backlog

I don't see a story here, but do suggest to talk to the 3rd party software owner and check wether this will be, or is already implemented. After doing so the assignee of this issue should put this either "On hold" with a remark that we're waiting for feedback, or just put this issue "in progress" and configure it correctly.

@mojtabaimani please from now on always work this way. Please don't let 3rd party software quirks end up as an issue that has no next steps.

Morriz avatar Sep 13 '21 08:09 Morriz

fixed

j-zimnowoda avatar Nov 08 '22 16:11 j-zimnowoda