Federico Andres Lois

Test this in DEBUG

I don't understand why it does not allow me to comment on your comments. So I will go one by one with quotes, but first thing first. I hate resharper...

We need to do a performance run to avoid regressions, correct.

6.1

Under risk assessment we decided to move this into the 6.2 release. We will include this PR into the feature branch instead. https://github.com/redknightlois/ravendb/tree/arm

LGTM

Sure. This is the benchmark ``` using System; using System.Linq; using BenchmarkDotNet.Analysers; using BenchmarkDotNet.Attributes; using BenchmarkDotNet.Configs; using BenchmarkDotNet.Environments; using BenchmarkDotNet.Jobs; using BenchmarkDotNet.Validators; namespace Micro.Benchmark.Benchmarks.Parsing { //[HardwareCounters(HardwareCounter.CacheMisses, HardwareCounter.TotalIssues, HardwareCounter.BranchMispredictions, HardwareCounter.InstructionRetired )]...

I have been looking on the code before reading this, and yes that works. I was going to workaround it by just converting to double instead. ``` instance.Length = 262144;instance.NonAsciiProbability...

This PR includes https://github.com/ravendb/ravendb/pull/19038 and show be reviewed after merging.

This one is ready to be reviewed.