rueidis icon indicating copy to clipboard operation
rueidis copied to clipboard

Support iter.Seq2 for *FieldValue

Open tamayika opened this issue 1 year ago • 1 comments

closes #355

I added iter.Seq2 support for HSET, HMSET, XADD which have FieldValue() method. We must support < go 1.23, so we must split file to other files. It's hard to support auto generation because current implementation does not support code splitting. So I hand-written the implementation. When go version in go.mod is go 1.23, I think we can support auto generation by adding flags to *.json and its structs.

Consideration

I named FieldValues, but this is maybe not good to support auto generation in the future because we must consider plural form correctly. Is FieldValueSeq better?

tamayika avatar Aug 30 '24 08:08 tamayika

Is FieldValueSeq better?

I think your original FieldValueIter is better.

rueian avatar Aug 30 '24 08:08 rueian