redis
feat: add unit field to bitcount
@rueian
Do we need to also do it for
func (c CacheCompat) BitCount(ctx context.Context, key string, bitCount *BitCount) *IntCmd
for this to work?
CacheCompat) BitCount(ctx context.Context, ke
Yes, we should support the Unit there too.
@rueian I was thinking whether I should continue here or on valkey-go You can suggest
Will that make me a contributor there too? As I would like to be so @rueian
Will that make me a contributor there too? As I would like to be so @rueian
Yes of course
I have some doubts
The command slice looks alright to me
But still I am getting an ERR syntax error for this
However, it works fine for BIT
@rueian
Further, In the container that I am using, I am able to get the response too
I have some doubts The command slice looks alright to me
But still I am getting an
ERR syntax errorfor this However, it works fine for BIT@rueian
Do you mean here? The RESP2 test suite is tested against Redis 5.
You need to wrap your new tests in a if block:
if resp3 {
bitCount = adapter.BitCount(ctx, "key", &BitCount{
Start: 1,
End: 1,
Unit: "BYTE",
})
Expect(bitCount.Err()).NotTo(HaveOccurred())
Expect(bitCount.Val()).To(Equal(int64(6)))
}