redis icon indicating copy to clipboard operation
redis copied to clipboard

fix the size of variable merge_sz in quicklist.c

Open FutabaRio opened this issue 3 years ago • 1 comments

11 was the size of header/trailer in the old structure Ziplist, but now the size of header/trailer in the new structure Listpack should be 7.

FutabaRio avatar Sep 19 '22 14:09 FutabaRio

Good catch, thx.

sundb avatar Sep 19 '22 15:09 sundb

thanks. ideally we would have an API or a define in listpack.h to expose these, but not sure it worth the trouble at this point, and the hard coded value was already present. hopefully with the improved comment we would be able to catch it faster next time 8-)

oranagra avatar Oct 19 '22 06:10 oranagra

FYI, that (rebase) merge wasn't needed. i was waiting for the CI tests of the original commit to finish, and then got destructed. thanks for catching this..

oranagra avatar Oct 19 '22 12:10 oranagra