redis-rcp icon indicating copy to clipboard operation
redis-rcp copied to clipboard

Create RCP10

Open therealbill opened this issue 9 years ago • 2 comments

An RCP to add two new sub-commands to CONFIG for better admin and issue reporting capabilities. This fulfills issue #16

therealbill avatar Jan 27 '16 16:01 therealbill

Solid and helpful suggestion IMO :+1:

Another direction for exploring this is to have each config entry have "fields", and then extend the CONFIG GET command with switches. Ideas for such fields could be:

  • current value
  • source for current (e.g. default, conf file, command line switch of the server, or runtime changes such as CONFIG SET - the latter perhaps with extended context info)
  • update timestamp
  • default value

The additional CONFIG GET <pattern> switches could be:

  • WITHTIMESTAMP
  • WITHSOURCE
  • DEFAULTS
  • DIFF

This would, however, require changing the RCP's gist to adding new modifiers to the existing subcommand instead of adding two new ones.

itamarhaber avatar Jan 29 '16 14:01 itamarhaber

@itamarhaber I initially thought about modifying the config get command. But this seems a much simpler route in terms if implementation as well as not overloading the config command. ;)

I do like the timestamp idea for determining when a value was changed. However, alternatively I'd rather see all config set calls logged complete w/values. Perhaps, if not terribly painful to implement, including the client information in the log entry. It would also be able to provide some improvement in access/config logging for those with auditing requirements. Hmm, maybe that deserves it's own RCP.

therealbill avatar Feb 01 '16 21:02 therealbill