fix scan iter command issued to different replicas
Pull Request check-list
- [x] Do tests and lints pass with this change?
- [x] lint passes
- [x] test passes on
Ubuntu 22.04,python3.11.2
Starting Redis tests
= 2352 passed, 1235 skipped, 849 deselected, 29 xpassed, 347 warnings in 163.65s (0:02:43) =
Waiting for 6 cluster nodes to become available
All nodes are available!
= 1571 passed, 1494 skipped, 1396 deselected, 4 xpassed, 244 warnings in 728.56s (0:12:08) =
- [x] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)? all succeeded in my fork.
- [x] Is the new or changed code fully tested? added tests coverage
- [x] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? bugfix only
- [x] I added some docstring to
redis.asyncio.sentinelmodule. I wanted to check if the rST syntax is correct, but this module is not included in the builddir's index, so I think it's no-op.
- [x] I added some docstring to
- [x] Is there an example added to the examples folder (if applicable)? bugfix only
- [x] Was the change added to CHANGES file? bugfix only
fix scan iter command issued to different replicas
Fixes #3197. See linked issue for full description of the bug
Some of the CI tests fails flakily with a segmentation fault - if i rerun the CI in my fork, it would work most of the time. But I don't have permission to rerun it in the main repository. Do you know whether this is expected? @gerzse Thank you!!
Some of the CI tests fails flakily with a segmentation fault - if i rerun the CI in my fork, it would work most of the time. But I don't have permission to rerun it in the main repository. Do you know whether this is expected? @gerzse Thank you!!
Those segmentation faults have been there for a long time, to be honest I have no idea why they happen. They are so annoying. Eventually I'll spend some time trying to dig deeper.