redis-py icon indicating copy to clipboard operation
redis-py copied to clipboard

Document XREAD of last message (+)

Open gerzse opened this issue 1 year ago • 3 comments

Pull Request check-list

Please make sure to review and check all of these items:

  • [ ] Do tests and lints pass with this change?
  • [ ] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • [ ] Is the new or changed code fully tested?
  • [ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • [ ] Is there an example added to the examples folder (if applicable)?
  • [ ] Was the change added to CHANGES file?

Description of change

Issue #3155

XREAD now supports reading the last message in the stream, with the + special Id. The code already supports this, so just add some documentation to an existing Jupyter notebook.

gerzse avatar Mar 18 '24 19:03 gerzse

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.81%. Comparing base (2f88840) to head (433eed8). Report is 19 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3188      +/-   ##
==========================================
- Coverage   91.84%   91.81%   -0.04%     
==========================================
  Files         128      128              
  Lines       33232    33328      +96     
==========================================
+ Hits        30523    30600      +77     
- Misses       2709     2728      +19     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 18 '24 19:03 codecov-commenter

@gerzse Is there a test case that covers this?

vladvildanov avatar Apr 29 '24 12:04 vladvildanov

@gerzse Is there a test case that covers this?

@vladvildanov Not an explicit unit test. The Jupyter notebook that I updated is "alive", in the sense that it can be executed, so it is sort of a proof that this works. I would not add unit tests for this, because it would test the server more than the client, I think.

gerzse avatar May 09 '24 07:05 gerzse