redis-py icon indicating copy to clipboard operation
redis-py copied to clipboard

Replace flake8+isort+black with `ruff`

Open akx opened this issue 1 year ago • 5 comments

Pull Request check-list

Please make sure to review and check all of these items:

  • [x] Do tests and lints pass with this change?
  • [x] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • [ ] Is the new or changed code fully tested?
  • [ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • [ ] Is there an example added to the examples folder (if applicable)?
  • [ ] Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

This PR replaces the use of flake8, isort, and black with Ruff.

More ruff rules could (should) be enabled later and the noqas taken care of.

akx avatar Feb 15 '24 12:02 akx

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2f88840) 91.84% compared to head (ae415eb) 91.84%. Report is 5 commits behind head on master.

Files Patch % Lines
redis/commands/graph/commands.py 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3147   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files         128      128           
  Lines       33232    33272   +40     
=======================================
+ Hits        30523    30560   +37     
- Misses       2709     2712    +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 18 '24 23:02 codecov-commenter

rebased. cc @dvora-h @chayim

akx avatar May 27 '24 17:05 akx

Rebased. Looks like @gerzse is on the move here, care to take a look?

akx avatar Jun 12 '24 06:06 akx

Rebased. cc @gerzse.

akx avatar Aug 26 '24 09:08 akx

Rebased. cc @vladvildanov (since you seem to be active on this repo).

akx avatar Oct 16 '24 05:10 akx

cc @petyaslavova

akx avatar Feb 25 '25 08:02 akx

@petyaslavova Conflict fixed. I also moved the configuration to pyproject.toml now that it's a thing, and made it more granular. Some of the non-free Redis modules' command modules don't adhere to usual Python naming, so they're excluded from the naming convention checks.

akx avatar Mar 05 '25 15:03 akx