redis-py icon indicating copy to clipboard operation
redis-py copied to clipboard

Python 3.12

Open chayim opened this issue 2 years ago • 8 comments

Updating the trove, and CI to support the Python 3.12 release announcement.

closes #3020

chayim avatar Oct 05 '23 07:10 chayim

https://github.com/MagicStack/uvloop/issues/567 is a precursor

chayim avatar Oct 05 '23 07:10 chayim

Today, uvloop released version 0.18.0, with support for Python 3.12, in case you want to retrigger the CI!

adamantike avatar Oct 14 '23 00:10 adamantike

Any news on this PR?

foarsitter avatar Dec 17 '23 14:12 foarsitter

Folks, I straight up forgot about this. We're getting it into the 5.1 beta with the removal of Python 3.7 too. @dvora-h leaving this with you.

chayim avatar Jan 01 '24 11:01 chayim

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4a66c1e) 92.05% compared to head (e6487ed) 92.05%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2979      +/-   ##
==========================================
- Coverage   92.05%   92.05%   -0.01%     
==========================================
  Files         128      128              
  Lines       33195    33199       +4     
==========================================
+ Hits        30558    30560       +2     
- Misses       2637     2639       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 10 '24 07:01 codecov-commenter

@adamantike thanks, used that.. but have an SSL context issue within the asyncio side. Are you familiar with this at all?

chayim avatar Jan 10 '24 08:01 chayim

Part of https://github.com/redis/hiredis-py/issues/167

chayim avatar Jan 10 '24 09:01 chayim

fyi, 3.12 also removes distutils so this import will need to be replaced

https://github.com/redis/redis-py/blob/07fc339b4a4088c1ff052527685ebdde43dfc4be/redis/commands/graph/query_result.py#L3

branchv avatar Apr 20 '24 18:04 branchv