redis-py icon indicating copy to clipboard operation
redis-py copied to clipboard

Establishing a connection to Redis shouldn't depend on setting the client_name

Open KTAtkinson opened this issue 2 years ago • 2 comments

REPRODUCTION STEPS

  1. Create a connection to Redis through Envoy proxy.
  2. Issue command SET key value

RESULT An error because this line is setting the client name, if it's provided, but the call fails because the proxy doesn't understand the command.

This is the error:

unsupported command 'CLIENT'

Notes Thought the Redis proxy should understand this command and this is the root cause of the issue, establishing a connection shouldn't depend on the CLIENT SETNAME command succeeding. A warning is probably sufficient because client_name is merely something that is for the convenience of the administrator of Redis, not something that is necessary for Redis to work.

KTAtkinson avatar Sep 14 '22 17:09 KTAtkinson

Could this change be backported to v3 as well?

KTAtkinson avatar Sep 19 '22 16:09 KTAtkinson

@KTAtkinson since your fix has been merged are you cool with the issue being closed?

sav-norem avatar Sep 29 '22 15:09 sav-norem