redis-py
redis-py copied to clipboard
Establishing a connection to Redis shouldn't depend on setting the client_name
REPRODUCTION STEPS
- Create a connection to Redis through Envoy proxy.
- Issue command
SET key value
RESULT An error because this line is setting the client name, if it's provided, but the call fails because the proxy doesn't understand the command.
This is the error:
unsupported command 'CLIENT'
Notes
Thought the Redis proxy should understand this command and this is the root cause of the issue, establishing a connection shouldn't depend on the CLIENT SETNAME
command succeeding. A warning is probably sufficient because client_name is merely something that is for the convenience of the administrator of Redis, not something that is necessary for Redis to work.
Could this change be backported to v3 as well?
@KTAtkinson since your fix has been merged are you cool with the issue being closed?