redis-py icon indicating copy to clipboard operation
redis-py copied to clipboard

running dump() fails when decode_responses=True in a pipeline

Open brianmaissy opened this issue 2 years ago • 8 comments

This is an extension of issue #1254, which was partially (but I belive not fully) resolved in #1731.

I think that when non-decodable commands are called from within a pipeline, they are decoded anyway.

See my comment on the original issue here: https://github.com/redis/redis-py/issues/1254#issuecomment-1003683647

brianmaissy avatar Jan 17 '22 11:01 brianmaissy

HI @brianmaissy This is a real bug, but however it doesn't make sense to use one of these commands in a pipeline, so for now we will leave it as an open bug.

dvora-h avatar Jan 20 '22 13:01 dvora-h

Why doesn't it make sense to use dump() in a pipeline? I do so in order to dump multiple keys.

brianmaissy avatar Jan 20 '22 14:01 brianmaissy

@brianmaissy We should support this (and don't today), the best answer is to use a connection where deconde_responses is False. While I realize this isn't ideal, this is the best current answer.

tl;dr yes a bug we should fix in the future, and labelled accordingly.

chayim avatar Jan 20 '22 14:01 chayim

Yeah that's the workaround I've been using. Thank you.

brianmaissy avatar Jan 20 '22 14:01 brianmaissy

Since we added the NEVER_DECODE target as part of another bug - closing this off. It works now.

chayim avatar Jul 13 '22 06:07 chayim

in what version is it fixed?

brianmedigate avatar Jul 13 '22 07:07 brianmedigate

I think > 4.0.1. @dvora-h am I right?

chayim avatar Jul 13 '22 09:07 chayim

I'm using 4.3.4, but it still doesn't work when the non-decodable command is used in a pipeline

brianmedigate avatar Jul 13 '22 10:07 brianmedigate

This issue is marked stale. It will be closed in 30 days if it is not updated.

github-actions[bot] avatar Jul 14 '23 00:07 github-actions[bot]

@chayim @dvora-h can you please confirm that this is still open?

brianmedigate avatar Jul 14 '23 10:07 brianmedigate

@brianmaissy Yes

dvora-h avatar Jul 16 '23 23:07 dvora-h