redis-doc icon indicating copy to clipboard operation
redis-doc copied to clipboard

updating sentinel docs

Open therealbill opened this issue 11 years ago • 4 comments

Now it is nice and clean. FIxes #404

therealbill avatar Sep 10 '14 20:09 therealbill

There are still some useful things in there, but I need to pick them out one-by-one (or rebase-and-fix)

badboy avatar Apr 30 '15 11:04 badboy

I've integrated the upstream additions as well as integrated comments from @badboy where they are still relevant.

therealbill avatar May 18 '15 18:05 therealbill

Thanks, will check again (though the many newly introduced line-breaks make this a little bit more difficult)

badboy avatar May 18 '15 18:05 badboy

Yeah, the over-long-lines really make improving it more difficult than it should be. I pondered doing it earlier but opted for a smaller change set. However, it's also a "do it once and you're done" option. With the upstream changes it made more sense to just "rip the bandage" off now.

It will make future changes easier to read because we won't have a 4-line "line" to see in a diff for a small change (such as typo correction) but instead just the line which was changed. That said, I do find reading a whole text document easier than reading snippets and diffs of same file first, then looking at the diffs to review specific changes such as spelling, typoes, or look for specific bits I have a question about. It will also make it easier to format various sections - such as letting Vim's markdown syntax understanding to format and identify it correctly. For example, bullet points are much easier to edit when formatted with proper indentation and line breaks.

therealbill avatar May 18 '15 21:05 therealbill

Closing as stale.

nermiller avatar Nov 10 '22 19:11 nermiller