redis-doc icon indicating copy to clipboard operation
redis-doc copied to clipboard

Lindex return code change for index is out of range.

Open hwware opened this issue 2 years ago • 5 comments

This request is to cover return value changes implemented as part of https://github.com/redis/redis/pull/12769.

hwware avatar Nov 15 '23 22:11 hwware

Deploy request for redis-doc pending review.

Visit the deploys page to approve it

Name Link
Latest commit 3d660c58fe8ba2d2bbeb301d858f2fca1763916b

netlify[bot] avatar Nov 15 '23 22:11 netlify[bot]

Hello Wen Hui. I'm one of the Redis technical writers. In this file on the main Redis source repo, there's the following definition:

      "reply_schema": {
           "oneOf": [
               {
                   "type": "null",
                   "description": "Index is out of range"
               },
               {
                   "description": "The requested element",
                   "type": "string"
               }
           ]
       },

If that reference is not correct, then it should also be amended.

dwdougherty avatar Nov 15 '23 23:11 dwdougherty

Thank you for reminding the details, I have updated the reply_schema in source repo as well. Please wait until https://github.com/redis/redis/pull/11924 gets merged. so that there will not be any confusions.

Thank you.

hwware avatar Nov 16 '23 15:11 hwware

Thanks, Wen Hui. Looks like this is going into 8.0, so I'll wait until that's out to merge this PR.

dwdougherty avatar Nov 16 '23 15:11 dwdougherty

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 21 '24 17:03 CLAassistant