redis-doc icon indicating copy to clipboard operation
redis-doc copied to clipboard

Update install from source instructions

Open Justman10000 opened this issue 3 years ago • 2 comments

Justman10000 avatar Jun 26 '22 18:06 Justman10000

Deploy request for redis-doc pending review.

Visit the deploys page to approve it

Name Link
Latest commit fb9fce330c84b063e112f7af0b51c01179b45a68

netlify[bot] avatar Jun 26 '22 18:06 netlify[bot]

@enjoy-binbin

Justman10000 avatar Oct 16 '22 16:10 Justman10000

why adding the install-redis-by-script? we generally do not depend on external things (distrust)

enjoy-binbin avatar Oct 17 '22 06:10 enjoy-binbin

why adding the install-redis-by-script? we generally do not depend on external things (distrust)

My script is open source, you can see the entire code...

Justman10000 avatar Oct 17 '22 14:10 Justman10000

My script is open source, you can see the entire code...

I know, but I don't think it is necessary.

i suggest removint it, and then maybe we can update this https://github.com/redis/redis-doc/pull/2014/files#r906949087

so that in my side, i can call help to merge this one

enjoy-binbin avatar Oct 18 '22 06:10 enjoy-binbin

My script is open source, you can see the entire code...

I know, but I don't think it is necessary.

How? I have specially written a script, what Redis completely set up, which you can also manage via the script! I have definitely not sat down at the script, only to read such sentences!

Justman10000 avatar Oct 18 '22 08:10 Justman10000

My script is open source, you can see the entire code...

i suggest removint it, and then maybe we can update this https://github.com/redis/redis-doc/pull/2014/files#r906949087

so that in my side, i can call help to merge this one

Like mine with update?

Justman10000 avatar Oct 18 '22 08:10 Justman10000

my advice has been given, thank you for your contribution, maybe @itamarhaber can help with it (the rest part)

enjoy-binbin avatar Oct 18 '22 09:10 enjoy-binbin

my advice has been given, thank you for your contribution, maybe @itamarhaber can help with it (the rest part)

Like mine?

Justman10000 avatar Oct 18 '22 11:10 Justman10000

@enjoy-binbin I don't think we use third-party repositories for any Redis docs. Also, this doc is undergoing major revisions. Ok to close for now?

nermiller avatar Nov 16 '22 00:11 nermiller

I don't think we use third-party repositories for any Redis docs. Also, this doc is undergoing major revisions. Ok to close for now?

yes, we should not use third-party repositories. undergoing major revisions, let's close it.

@Justman10000 thanks for the contribution, and sorry for the delay, feel free to refresh it

enjoy-binbin avatar Nov 16 '22 06:11 enjoy-binbin

I don't think we use third-party repositories for any Redis docs. Also, this doc is undergoing major revisions. Ok to close for now?

yes, we should not use third-party repositories. undergoing major revisions, let's close it.

@Justman10000 thanks for the contribution, and sorry for the delay, feel free to refresh it

WHY NOT? Then regulate the shit yourself! No more support of any kind from me!

Justman10000 avatar Nov 16 '22 15:11 Justman10000

we have explained our reasons, and i think i have made it clear. i'm not targeting you (or anyone), if you have better opinions, you can continue to put forward we all have the same common goal and that is to make it better

enjoy-binbin avatar Nov 16 '22 16:11 enjoy-binbin

we have explained our reasons, and i think i have made it clear. i'm not targeting you (or anyone), if you have better opinions, you can continue to put forward we all have the same common goal and that is to make it better

Well, I have submitted plenty of PRs in quite a few projects! Since one has times almost the face full, if loosely 80-85% of all PRs are closed! Some then even without justification...

And I would also take good care of the script, PRs are also welcome... So where is the problem? If the projects I write these scripts for don't accept them, what's the point of putting out there? After all, it has added value for the community....

Justman10000 avatar Nov 16 '22 16:11 Justman10000