node-redis
node-redis copied to clipboard
Could you update code to hide password for sercure?
Issue
Describe your issue here When dump or error, sometime redis client handle was dumped or jsonized, it could br show the redis password. Could you please to hide Redis connection password for secure?

Environment
-
Node.js Version:
Redis can run
-
Redis Version:
2.8.0
-
Platform:
Mac/Linux
Jumping on this as even in the logs on a failed connect (error was using redis:// instead of rediss://) the username & password are in plain text, which is a potential high severity security issue that should be fixed asap.
I don't believe this is an issue anymore.
When logging a redis client object the following is logged:
RedisClient {
_events: [Object: null prototype] { error: [Function (anonymous)] },
_eventsCount: 1,
_maxListeners: undefined,
commandOptions: [Function: commandOptions],
select: [AsyncFunction: SELECT],
subscribe: [Function: SUBSCRIBE],
unsubscribe: [Function: UNSUBSCRIBE],
pSubscribe: [Function: PSUBSCRIBE],
pUnsubscribe: [Function: PUNSUBSCRIBE],
sSubscribe: [Function: SSUBSCRIBE],
sUnsubscribe: [Function: SUNSUBSCRIBE],
quit: [Function: QUIT],
multi: [Function: MULTI],
[Symbol(kCapture)]: false
}
For your information, it's seem to be changed and impacted a fix!