lettuce icon indicating copy to clipboard operation
lettuce copied to clipboard

fix: safety close in AsyncConnectionProvider #2935

Open Roiocam opened this issue 1 year ago • 2 comments

Motivation

ConcurrentHashMap didn't guarantee the iterator consistency with entries...

Make sure that:

  • [x] You have read the contribution guidelines.
  • [ ] You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • [x] You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • [ ] You submit test cases (unit or integration tests) that back your changes.

Roiocam avatar Aug 15 '24 17:08 Roiocam

Hey @Roiocam

is this related to #2935?

tishun avatar Aug 30 '24 19:08 tishun

Hey @Roiocam

is this related to #2935?

Yes, I knew it wasn't thread-safe, but my original post didn't figure out the actually reason.

I think my latest commit with a test case can strongly explain why, it also updates the solution of this issue.

Roiocam avatar Aug 30 '24 21:08 Roiocam