lettuce
lettuce copied to clipboard
Ensure CI validates RESP2 and RESP3
Verified that there are tests running agains RESP2 currently on the pipeline:
[INFO] Running io.lettuce.core.ConnectionCommandIntegrationTests
[INFO] Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.682 s -- in io.lettuce.core.ConnectionCommandIntegrationTests
[INFO] Running io.lettuce.core.ClientOptionsIntegrationTests
[INFO] Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.881 s -- in io.lettuce.core.ClientOptionsIntegrationTests
[INFO] Running io.lettuce.core.cluster.AsyncConnectionProviderIntegrationTests
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.010 s -- in io.lettuce.core.cluster.AsyncConnectionProviderIntegrationTests
[INFO] Running io.lettuce.core.support.caching.ClientsideCachingIntegrationTests
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.396 s -- in io.lettuce.core.support.caching.ClientsideCachingIntegrationTests
[INFO] Running io.lettuce.core.pubsub.PubSubCommandResp2Test
Warning: Tests run: 29, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 0.738 s -- in io.lettuce.core.pubsub.PubSubCommandResp2Test
@tishun The intention is to ensure that both RESP2 and RESP3 replies of all commands are being tested in single CI run (i.e. GitHub Action). Is it being done?
Hey @sazzad16 , let me check that, but if we are talking about all commands then probably the answer is no. Do we have that in other clients?
Do we have that in other clients?
They either have that or are trying to have.
IMHO, at least all the data structure commands should be tested.
Makes sense, let's have this issue as a research and we can create a couple more once we find good targets to test