jedis icon indicating copy to clipboard operation
jedis copied to clipboard
verified publisher icon redis

Remove unused leftovers from JedisSharding

Open uglide opened this issue 1 month ago • 4 comments

Continuation of #4311

uglide avatar Nov 05 '25 08:11 uglide

Test Results

   281 files  ±0     281 suites  ±0   11m 31s ⏱️ -21s 10 197 tests ±0  10 143 ✅ ±0  54 💤 ±0  0 ❌ ±0   2 712 runs  ±0   2 712 ✅ ±0   0 💤 ±0  0 ❌ ±0 

Results for commit bd46c4a0. ± Comparison against base commit c18881eb.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Nov 05 '25 09:11 github-actions[bot]

@ggivo I don't think it's a breaking change, since the files are internal and not used extrernaly.

uglide avatar Nov 05 '25 10:11 uglide

@uglide What do you mean by not used externaly? They are marked @deprecated but are public and not documented as internal in comments or annotated with @Internal.

ggivo avatar Nov 06 '25 07:11 ggivo

@ggivo see https://github.com/redis/jedis/pull/4311/files#diff-a1c95bbe6e3dc70afb41f29448973d7f61021891667a064b67d5bbc2603748b3L32-L35 This PR removes leftovers that were overseen during the JedisSharding removal. Hashing was used only for JedisSharding and is unlikely to be used without it.

uglide avatar Nov 06 '25 09:11 uglide