jedis icon indicating copy to clipboard operation
jedis copied to clipboard

Fix return value of HRANDFIELD With Values when count is negative #3017

Open s-sathish opened this issue 2 years ago • 1 comments

Fix return value of HRANDFIELD With Values when count is negative https://github.com/redis/jedis/issues/3017

s-sathish avatar Jun 23 '22 09:06 s-sathish

Codecov Report

Merging #3049 (a1577ac) into master (f66cacd) will increase coverage by 0.30%. The diff coverage is 88.88%.

:exclamation: Current head a1577ac differs from pull request most recent head 1d0ed44. Consider uploading reports for the commit 1d0ed44 to get more accurate results

@@             Coverage Diff              @@
##             master    #3049      +/-   ##
============================================
+ Coverage     52.25%   52.56%   +0.30%     
- Complexity     3342     3343       +1     
============================================
  Files           218      218              
  Lines         13608    13589      -19     
  Branches        781      785       +4     
============================================
+ Hits           7111     7143      +32     
+ Misses         6251     6199      -52     
- Partials        246      247       +1     
Impacted Files Coverage Δ
src/main/java/redis/clients/jedis/Jedis.java 84.92% <ø> (ø)
...ava/redis/clients/jedis/MultiNodePipelineBase.java 21.70% <ø> (+0.02%) :arrow_up:
src/main/java/redis/clients/jedis/Pipeline.java 7.81% <ø> (+<0.01%) :arrow_up:
...main/java/redis/clients/jedis/TransactionBase.java 11.33% <ø> (+0.01%) :arrow_up:
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 53.37% <ø> (+0.87%) :arrow_up:
...dis/clients/jedis/commands/HashBinaryCommands.java 0.00% <ø> (ø)
...ava/redis/clients/jedis/commands/HashCommands.java 100.00% <ø> (ø)
...nts/jedis/commands/HashPipelineBinaryCommands.java 0.00% <ø> (ø)
...s/clients/jedis/commands/HashPipelineCommands.java 0.00% <ø> (ø)
.../main/java/redis/clients/jedis/BuilderFactory.java 67.44% <87.50%> (+1.11%) :arrow_up:
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f66cacd...1d0ed44. Read the comment docs.

codecov-commenter avatar Jun 23 '22 09:06 codecov-commenter

Hey @s-sathish! How are you doing? Are you available to resolve the conflicts?

sazzad16 avatar May 18 '23 13:05 sazzad16

Hey @s-sathish! How are you doing? Are you available to resolve the conflicts?

Hi @sazzad16! I'm doing good. I hope you are doing well, too Yes. I will resolve the conflicts in sometime

s-sathish avatar May 18 '23 13:05 s-sathish

Messed up while doing rebase, so closed this PR. Not sure what went wrong. Again, I just opened a new PR from the fork and all looks good. Tracking it now from here - https://github.com/redis/jedis/pull/3425

s-sathish avatar May 18 '23 14:05 s-sathish