jedis icon indicating copy to clipboard operation
jedis copied to clipboard

Support RESET command (#2952)

Open ihaohong opened this issue 2 years ago • 4 comments

ihaohong avatar Jun 04 '22 05:06 ihaohong

Hi, I fixed the unit test failure, and run it in my workflow: https://github.com/ihaohong/jedis/runs/6883129332?check_suite_focus=true, please review this pull request again, thanks.

ihaohong avatar Jun 14 '22 15:06 ihaohong

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d2f6712) 71.52% compared to head (8205ccc) 71.46%.

:exclamation: Current head 8205ccc differs from pull request most recent head 5469680. Consider uploading reports for the commit 5469680 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3015      +/-   ##
============================================
- Coverage     71.52%   71.46%   -0.06%     
+ Complexity     4851     4848       -3     
============================================
  Files           288      288              
  Lines         15461    15464       +3     
  Branches       1095     1095              
============================================
- Hits          11058    11051       -7     
- Misses         3927     3934       +7     
- Partials        476      479       +3     
Files Coverage Δ
.../main/java/redis/clients/jedis/CommandObjects.java 85.66% <100.00%> (+0.01%) :arrow_up:
src/main/java/redis/clients/jedis/Jedis.java 85.21% <100.00%> (-0.04%) :arrow_down:
src/main/java/redis/clients/jedis/Protocol.java 89.50% <100.00%> (-1.11%) :arrow_down:
...a/redis/clients/jedis/commands/ServerCommands.java 0.00% <ø> (ø)

... and 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 14 '22 17:06 codecov-commenter

Hi, what else need me to do for this pull request?

ihaohong avatar Jun 17 '22 07:06 ihaohong

@ihaohong Nothing ATM. Thank you for your patience.

sazzad16 avatar Jun 17 '22 11:06 sazzad16

@ihaohong Apologies for late and thanks for your contribution!

sazzad16 avatar Nov 02 '23 11:11 sazzad16