jedis icon indicating copy to clipboard operation
jedis copied to clipboard

JedisSentinelPool requires port whereas the JedisPool does not. Should default to Protocol.DEFAULT_SENTINEL_PORT

Open joetennant opened this issue 8 years ago • 3 comments

JedisSentinelPool parses the set of sentinel addresses (as string) and converts them to HostAndPort instances. However, it always attempts to parse the port value and fails when no port is provided.

Instead this should act like JedisPool and use the default sentinel port as defined by Protocol when no port is provided.

joetennant avatar Aug 12 '15 15:08 joetennant

+1

samklr avatar Mar 22 '16 07:03 samklr

Seems right to implement. Anyone willing to craft a PR?

marcosnils avatar Mar 26 '16 00:03 marcosnils

Is this issue still accepting PRs?

Sufiyan1997 avatar May 24 '20 11:05 Sufiyan1997