ioredis icon indicating copy to clipboard operation
ioredis copied to clipboard

fix: fix issue of cases where prevCondition is a subscriber

Open prathik opened this issue 1 year ago • 2 comments

The current logic does an or operation between condition and prevCondition.

In condition the value of subscriber could be false and in prevCondition it could be a subscription set.

The change addresses this by picking the first non false subscriber.

Added some debug logs to show the case (in the image).

Screenshot 2024-07-05 at 11 40 55 PM

prathik avatar Jul 05 '24 18:07 prathik

@leibale @luin any advice on this?

prathik avatar Jul 05 '24 18:07 prathik

@prathik luin is no longer the maintainer AFAIK and the redis team seems to focus on https://github.com/redis/node-redis, you could move this PR to https://github.com/valkey-io/iovalkey which is the most promising fork IMO.

lukas-becker0 avatar Aug 28 '24 21:08 lukas-becker0

This pull request has been automatically marked as stale due to inactivity. It will be closed in 30 days if no further activity occurs.

github-actions[bot] avatar Sep 21 '25 00:09 github-actions[bot]

This pull request has been automatically closed due to inactivity. If you would like to continue this work, please reopen the PR or create a new one.

github-actions[bot] avatar Oct 22 '25 00:10 github-actions[bot]