ioredis icon indicating copy to clipboard operation
ioredis copied to clipboard

tls option should be sentinelTLS

Open ile opened this issue 3 years ago • 2 comments

I believe tls in this https://github.com/luin/ioredis#tls-options:

const redis = new Redis({
  host: "localhost",
  tls: {
    // Refer to `tls.connect()` section in
    // https://nodejs.org/api/tls.html
    // for all supported options
    ca: fs.readFileSync("cert.pem"),
  },
});

should be sentinelTLS.

ile avatar Nov 13 '21 07:11 ile

Or, actually it seems that both (tls and sentinelTLS) are needed and they should contain the same content? I may be wrong.

ile avatar Nov 15 '21 07:11 ile

There's also a enableTLSForSentinelMode option that might need to be true. Not sure why we don't just check the presence for sentinelTLS.

... it got added in https://github.com/luin/ioredis/pull/773, but there aren't any details about it.

marcbachmann avatar Mar 16 '22 00:03 marcbachmann