ioredis icon indicating copy to clipboard operation
ioredis copied to clipboard

ISSUE-1098 Allow reconnection closed nodes in cluster mode #1098

Open yangyang198703 opened this issue 4 years ago • 2 comments

yangyang198703 avatar Apr 22 '20 14:04 yangyang198703

It's hard for users to tell in advance whether a node is lost temporarily or permanently so I don't think we should make this behavior configurable.

The current logic should be able to re-discover the unjoined node or did you find anything wrong?

luin avatar May 30 '20 04:05 luin

Thanks for replying!

It's hard for users to tell in advance whether a node is lost temporarily or permanently so I don't think we should make this behavior configurable.

I agree, that's why I defensively do this retry when and only when the node has been connected once.

The current logic should be able to re-discover the unjoined node or did you find anything wrong?

Yes, the current logic works but with a problem of performance. It will cause disconnections / reconnections of all the nodes if any single node lost connection.

yangyang198703 avatar May 30 '20 07:05 yangyang198703