hiredis icon indicating copy to clipboard operation
hiredis copied to clipboard

Published 20 hours ago • verified publisher icon redis

Removed unused import

Open bjornleffler opened this issue 2 years ago • 3 comments

This line causes a build breakage in environments that only expose some (public?) OpenSSL header files.

I'm not an expert in the area. Just noticed it and submitting a simple fix for it.

bjornleffler avatar Aug 27 '21 01:08 bjornleffler

Friendly ping on this.

bjornleffler avatar Sep 14 '21 10:09 bjornleffler

Oh... @bjosv so this PR is should instead be rejected then?

zuiderkwast avatar Dec 17 '21 15:12 zuiderkwast

@zuiderkwast I believe so. @bjornleffler Interesting, err.h is usually included in the required openssl-devel package or via Brews openssl on Mac, Windows I dont know. Which OS/distribution are you using? and which build system (Make or via CMake)?

bjosv avatar Dec 20 '21 08:12 bjosv

Going to close this, as it looks like we do sometimes need the header.

michael-grunder avatar Sep 05 '22 20:09 michael-grunder