reserved identifier violation

[elfring]

I would like to point out that identifiers like “__HIREDIS_H” and “__NET_H” do not fit to the expected naming convention of the C language standard. Would you like to adjust your selection for unique names?

[mnunberg]

I'm all for it! -- unfortunately however, I don't know if a massive commit changing these names is going to be helpful as it's going to pollute the commit logs..

[michael-grunder]

I put together a commit to fix this over on my fork and we'll use #807 to bikeshed whether we want to include it for v1.0.0

[elfring]

Additional analysis tools can point software development concerns out for further source code places.

How do you think about to avoid that this software depends on undefined behaviour?

[michael-grunder]

Hi @elfring I mostly wanted to bump the issue so I didn't forget about it before releasing v1.0.0.

The branch on my fork was just a quick and dirty search/replace. If we choose to include the changes I'll make sure we abide by all naming standards (and yes I don't think NET_H would be nearly unique enough :joy:)

[elfring]

Would you like to reopen this issue until it will be completely fixed?