go-redis icon indicating copy to clipboard operation
go-redis copied to clipboard

depends on old forks of ginkgo ang gomega

Open come-maiz opened this issue 5 months ago • 1 comments

In https://github.com/redis/go-redis/pull/2371/files#diff-bad3813d50ebba4650caa871281a86833024b6876453dfe1fc0d7c853b904453 the ginkgo and gomega dependencies were replaced by forks.

These forks haven't been updated in 2 years, while the original projects keep being actively maintained.

I think it's healthier to use the original projects instead of forking them, even if that will require additional dependencies. It is healthier to contribute with these upstreams, and to frequently review their code and to update downstream code to use the new features. Otherwise, these projects are not the correct dependency for what is needed.

Please update these two dependencies to use onsi's versions.

come-maiz avatar Jul 14 '25 05:07 come-maiz

Hello @come-maiz Thanks for raising this issue. We are planning to revisit the testing framework in the near future.

htemelski-oss avatar Jul 14 '25 08:07 htemelski-oss