go-redis icon indicating copy to clipboard operation
go-redis copied to clipboard

RediSearch Support

Open ofekshenawa opened this issue 1 year ago β€’ 1 comments

ofekshenawa avatar Nov 16 '23 22:11 ofekshenawa

how is this mr going?

jiangtao244 avatar Mar 27 '24 02:03 jiangtao244

@ofekshenawa @vladvildanov @chayim @jiangtao244 hi guys, sorry for interrupting, we stucked with using RediSearch in golang, under RESP3 protocol, especially with FT.AGGREGATE and FT.SEARCH commands:

I found that RESP3 testing code was commented for some reason, so in production it doesn't work at all (incorrect response parsing) β€” any luck with supporting third version of protocol?

If there is no pull request which fixes that problem, I created a fork with completed implementation of supporting "new" version of response, should I create a pull request for that?

quenbyako avatar Jul 18 '24 10:07 quenbyako

@quenbyako Thank you for reaching us out! Sorry for the bad experience, but we had to rollback our latest release that brings a support for RediSearch, so this functionality is considered non-finished. We're planning to release it very soon, but on the first stage it will be RESP2 only, RESP3 support will be a part of the release after this.

Stay tuned for update in near future!

vladvildanov avatar Jul 18 '24 11:07 vladvildanov

@vladvildanov Glad that you responded so quick, thank you πŸ˜ŠπŸ™

Regarding to features rollback: Was this lack of compatibility for RESP3 documented somewhere? Cause I spent yesterday nearly 5 hours to undestand what's happened, and it was hell, there is completely no info about this one...

I implemented quick and dirty support for ft.aggregate command, please, take a look if you have some time, for our project redisearch is really important part, and I really want to collaborate with you guys on that feature addition, if that's possible πŸ€—

quenbyako avatar Jul 18 '24 11:07 quenbyako

@quenbyako The RESP3 will be partially compatible in near future and will be explained in the statement we prepare for community. We apologise that it forced you to dig into it, it was totally not planned to release it "that" way. We promise to properly communicate it with you πŸ‘Œ

vladvildanov avatar Jul 18 '24 12:07 vladvildanov

@quenbyako Join our discord community, there's a channel dedicated to go-redis as well https://discord.gg/zhvcaDMc

vladvildanov avatar Jul 18 '24 12:07 vladvildanov