500 Internal Server Error when checking history of sub page with quotation marks

[twied]

• create new otterwiki instance: $ podman run -p 8080:80 docker.io/redimp/otterwiki:2

• create page with a title that has spaces and quotes, e.g. foo "bar"/baz.

• go to changelog http://localhost:8080/-/changelog page and click on the just created revision (http://localhost:8080/-/commit/e196d9)

• Get 500 Internal Server Error

[redimp]

Hey @twied, thanks for reporting this.

Behind the 500 was a unidiff.errors.UnidiffParseError raised.

unidiff.errors.UnidiffParseError: Target without source: +++ "b/foo \"bar\"/baz.md"	

Looking into it!

[redimp]

This is a bug in python-unidiff, whis has been reported and half fixed https://github.com/matiasb/python-unidiff/commit/2771a878f7bc6619e625feb4dbad3427f57f5237 but never made it into a release: https://github.com/matiasb/python-unidiff/issues/113.

[redimp]

I wrapped up a workaround, would appreciate further testing here: https://testing.otterwiki.com/Issues/%22Quote%22%20In%20Filename%20Issue%20244.

Note: Like demo.otterwiki.com this site will reset after some time, please share anything you run into here in the ticket. Thanks!

[twied]

lgtm, thank you! 👍

[redimp]

Thanks for testing! You came up with way more stuff as I thought of .. like just " as pagename. 😅

Will make a new release with these fixes later today.

[redimp]

Released in v2.10.6.