jetlag icon indicating copy to clipboard operation
jetlag copied to clipboard

Apply ansible-lint default rules

Open rabin-io opened this issue 9 months ago • 3 comments

Current state,

                        Rule Violation Summary                        
 count tag                      profile    rule associated tags       
    13 command-instead-of-shell basic      command-shell, idiom       
     2 key-order[task]          basic      formatting                 
     1 literal-compare          basic      idiom                      
    70 jinja[spacing]           basic      formatting (warning)       
     2 schema[playbook]         basic      core                       
     9 name[missing]            basic      idiom                      
     9 yaml[colons]             basic      formatting, yaml           
     1 yaml[commas]             basic      formatting, yaml           
     2 yaml[comments]           basic      formatting, yaml           
     2 yaml[empty-lines]        basic      formatting, yaml           
     2 yaml[hyphens]            basic      formatting, yaml           
   308 yaml[indentation]        basic      formatting, yaml           
    92 yaml[line-length]        basic      formatting, yaml           
     8 yaml[octal-values]       basic      formatting, yaml           
     4 yaml[trailing-spaces]    basic      formatting, yaml           
    31 yaml[truthy]             basic      formatting, yaml           
    12 name[template]           moderate   idiom                      
     3 name[casing]             moderate   idiom                      
    93 risky-file-permissions   safety     unpredictability           
    21 risky-shell-pipe         safety     command-shell              
    11 ignore-errors            shared     unpredictability           
   153 no-changed-when          shared     command-shell, idempotency 
     1 no-handler               shared     idiom                      
   589 fqcn[action-core]        production formatting                 
    20 fqcn[action]             production formatting                 
     2 run-once[task]                      idiom                      

Failed: 1391 failure(s), 70 warning(s) on 259 files. Last profile that met the validation criteria was 'min'.

A quick win/fix with ansible-lint --fix can reduce this to

$ ansible-lint --fix=fqcn ansible/*

Modified 104 files.
                       Rule Violation Summary                       
 count tag                      profile  rule associated tags       
    13 command-instead-of-shell basic    command-shell, idiom       
     2 key-order[task]          basic    formatting                 
     1 literal-compare          basic    idiom                      
    70 jinja[spacing]           basic    formatting (warning)       
     2 schema[playbook]         basic    core                       
     9 name[missing]            basic    idiom                      
     2 yaml[comments]           basic    formatting, yaml           
    18 yaml[line-length]        basic    formatting, yaml           
    12 name[template]           moderate idiom                      
     3 name[casing]             moderate idiom                      
    93 risky-file-permissions   safety   unpredictability           
    21 risky-shell-pipe         safety   command-shell              
    11 ignore-errors            shared   unpredictability           
   153 no-changed-when          shared   command-shell, idempotency 
     1 no-handler               shared   idiom                      
     2 run-once[task]                    idiom                      

Failed: 343 failure(s), 70 warning(s) on 259 files. Last profile that met the validation criteria was 'min'.

rabin-io avatar May 13 '24 13:05 rabin-io