badfish icon indicating copy to clipboard operation
badfish copied to clipboard

"Ready for review" template not linked

Open sarahbx opened this issue 10 months ago • 3 comments

Hello,

I did not locate the template in the repo, do you have a link for this? https://github.com/redhat-performance/badfish/blob/c9e0b2b9996e88d3185dfdada334688795b8d0f3/CONTRIBUTING.md?plain=1#L58

Thank you! Sarah

sarahbx avatar Sep 04 '23 19:09 sarahbx

Thank you for raising this. Looks like we never included it. Created a new PR with the template which should autopopulate when creating a new PR.

grafuls avatar Sep 05 '23 08:09 grafuls

I believe this needs to be in a different location for it to populate correctly.

currently (in development branch): .github/ISSUE_TEMPLATE/pull_request_template.md

should be: .github/PULL_REQUEST_TEMPLATE/pull_request_template.md or .github/pull_request_template.md

sarahbx avatar Sep 12 '23 13:09 sarahbx

Thanks for pointing that out, will relocate the file on the next PR.

grafuls avatar Oct 31 '23 12:10 grafuls