JetSki icon indicating copy to clipboard operation
JetSki copied to clipboard

Virtual environment approach no longer supported for badfish command

Open dustinblack opened this issue 3 years ago • 0 comments

Latest Badfish has some issues on using virtual python environment and venv will not be supported in the long run.

We have replaced most uses of venv in #229, but one usage remains in the bootstrap role:

https://github.com/redhat-performance/JetSki/blob/ab0bba1094226119fca1f7feb4bdc3b73d6c67e9/ansible-ipi-install/roles/bootstrap/vars/main.yml#L3

This var is used in the tasks here: https://github.com/redhat-performance/JetSki/blob/ab0bba1094226119fca1f7feb4bdc3b73d6c67e9/ansible-ipi-install/roles/bootstrap/tasks/20_reprovision_nodes.yml

Per https://github.com/redhat-performance/JetSki/pull/229#issuecomment-1180594257 from Murali, we cannot use the containerized approach that we are using elsewhere in this case because we also run this in a pipeline with Airflow where Jetski is containerized.

We need to replace the badfish venv command here with a straight standalone CLI method.

dustinblack avatar Jul 13 '22 08:07 dustinblack