vale-at-red-hat icon indicating copy to clipboard operation
vale-at-red-hat copied to clipboard

Published 20 hours ago • verified publisher icon redhat-documentation

Valid conditions: false positive

Open michaelryanpeter opened this issue 5 months ago • 3 comments

Describe the bug Currently, the valid conditions rule prints an error for the valid use case of using an inline conditional. Here is a link to the error: https://github.com/openshift/openshift-docs/pull/82304#discussion_r1773536688

Examples:

  • This word or expression triggers an illegitimate vale alert:

ifndef::olmv1-pullsecret-proc[For more information, see "Creating a pull secret for catalogs hosted on a secure registry".]

I am not sure if the regex can be extended to check for this use case. This might just be a false positive that we need to accept, since having a rule that catches open conditions seems more important than not flagging an error on this edge case.

michaelryanpeter avatar Sep 24 '24 15:09 michaelryanpeter