yaml-language-server icon indicating copy to clipboard operation
yaml-language-server copied to clipboard

Published 20 hours ago • verified publisher icon redhat-developer

Fix missing quote and syntax highlight in README

Open Legend-Master opened this issue 9 months ago • 5 comments

What does this PR do?

Fix some missing quotes and syntax highlighting in README

Before

image

After

image

Legend-Master avatar Nov 26 '23 17:11 Legend-Master

Coverage Status

coverage: 83.813%. remained the same when pulling affada7e6bcdb545aea6e15076136684df58faf7 on Legend-Master:readme-code-block-fix into ed03cbf71ade29ea62b4bcac0d8952195fd6969d on redhat-developer:main.

coveralls avatar Nov 26 '23 17:11 coveralls

Hey @Legend-Master I am seeing this after posting #945.

Your solution is changing the examples to make them JSON, while I believe that they were written to be YAML. Can you please have a look at #945 and see if it makes sense?

pierreprinetti avatar Dec 11 '23 11:12 pierreprinetti

I think they're json files used by code editors, not yaml files (but since yaml contains/allows all json things, syntax highlighting should still works)

image

Legend-Master avatar Dec 11 '23 11:12 Legend-Master

I think they're json files used by code editors, not yaml files

Oh! Interesting.

pierreprinetti avatar Dec 11 '23 11:12 pierreprinetti

@gorkem PTAL

pierreprinetti avatar Dec 11 '23 11:12 pierreprinetti