yaml-language-server icon indicating copy to clipboard operation
yaml-language-server copied to clipboard

Published 20 hours ago • verified publisher icon redhat-developer

Export Telemetry type

Open remcohaszing opened this issue 2 years ago • 4 comments

What does this PR do?

Export the Telemetry type.

Alternatively it could be defined in yamlLanguageService.ts.

What issues does this PR fix or reference?

This is used by monaco-yaml.

Is it tested? How?

No.

remcohaszing avatar Sep 06 '23 11:09 remcohaszing

Can we alternately add telemetry.ts to index.ts ? This would also export TelemetryEvent which I feel maybe needed if a client really wants to send events.

gorkem avatar Oct 07 '23 16:10 gorkem

I think you meant to move it into yamlLanguageService, of which everything is also re-exported in index.ts. Otherwise language service code would have to import language server code.

remcohaszing avatar Oct 07 '23 16:10 remcohaszing

Coverage Status

coverage: 84.071%. remained the same when pulling 4212cc98a05f78fe1a3f1e2856ead54b4992a181 on remcohaszing:export-telemetry into d354c58a480dd9d3ef6b754377352b481163f60a on redhat-developer:main.

coveralls avatar Dec 19 '23 14:12 coveralls