yaml-language-server icon indicating copy to clipboard operation
yaml-language-server copied to clipboard

Published 20 hours ago • verified publisher icon redhat-developer

Feat: add title source hover settings

Open q-rault opened this issue 2 years ago • 5 comments

What does this PR do?

It adds hover settings to enable/disable Title and Source from hover tooltip

What issues does this PR fix or reference?

It is based on the work of @nikalexxx from 2022/05, see here for context and pictures of what the PR does Original didn't pass the CI because of format/lint issues. It is now correctly linted

Is it tested? How?

Two unitary tests were added, correctly showing the result when the new settings are enabled/disabled

q-rault avatar Jun 03 '23 10:06 q-rault

Coverage Status

coverage: 83.396% (+0.03%) from 83.365% when pulling 7a66521b76c53758af83bf1a1150b6f1818d4d0f on q-rault:feat/add-title-source-hover-settings into b0f60d4e3df1b453fb4976ab71e16e4bddf92c50 on redhat-developer:main.

coveralls avatar Jun 04 '23 15:06 coveralls

@msivasubramaniaan Are you able to take a look at this? or @gorkem Do you know who owns this after you've left red hat?

jpinkney-aws avatar Apr 26 '24 13:04 jpinkney-aws

@q-rault please resolve conflicts.

@jpinkney-aws I'll review it by next week

msivasubramaniaan avatar Apr 26 '24 14:04 msivasubramaniaan

@msivasubramaniaan I wanted to kindly request your review on the changes made in this pull request when you have a chance. We are also interested in this feature

aderende avatar May 08 '24 08:05 aderende

@jpinkney-aws

@gorkem Do you know who owns this after you've left red hat?

🤷 probably under staffed

gorkem avatar May 09 '24 19:05 gorkem