yaml-language-server icon indicating copy to clipboard operation
yaml-language-server copied to clipboard

Published 20 hours ago • verified publisher icon redhat-developer

Update TypeScript target from es5 to es2020

Open remcohaszing opened this issue 3 years ago • 1 comments

What does this PR do?

es2020 is compatible with Node.js 14 and all modern browsers. Notably this no longer transpiles async/await syntax.

What issues does this PR fix or reference?

N/A

Is it tested? How?

npm test

remcohaszing avatar Sep 20 '22 13:09 remcohaszing

Oh, tests run against Node 12. It’s no longer supported, but if yaml-language-server needs to support it, the appropriate target would be es2019.

remcohaszing avatar Sep 20 '22 14:09 remcohaszing

I do not see any issue with moving to a newer nodejs version. 12 is EOL anyway.

gorkem avatar Sep 23 '22 16:09 gorkem

@remcohaszing I think this will pass now if you rebase

gorkem avatar Sep 26 '22 15:09 gorkem

Thanks! Rebased

remcohaszing avatar Oct 01 '22 09:10 remcohaszing

Coverage Status

Coverage decreased (-0.1%) to 82.94% when pulling 08e2bec1ee62adfa39423f297795eff0a1d03416 on remcohaszing:update-typescript-target into 6b532a50547b3edf137a6838a2688ba0e19090a6 on redhat-developer:main.

coveralls avatar Oct 01 '22 09:10 coveralls