yaml-language-server icon indicating copy to clipboard operation
yaml-language-server copied to clipboard

Published 20 hours ago • verified publisher icon redhat-developer

Add on type conversion of tab char to spaces

Open evidolob opened this issue 4 years ago • 3 comments

What does this PR do?

Add on type conversion of tab char to spaces

What issues does this PR fix or reference?

#244

Is it tested? How?

With unit test. Unfortunately vscode doesn't trigger onTypeFormatting when \\t character is typed, maybe I need to report an issue for it.

evidolob avatar Jan 20 '21 08:01 evidolob

@mickaelistria Can you check this PR, as I won't able to test it in vscode?

evidolob avatar Jan 20 '21 08:01 evidolob

Coverage Status

Coverage increased (+0.3%) to 76.427% when pulling 639ae4db40ab59065e4205f6f05ba81b2a4d65f1 on evidolob:convert-tab-to-spaces into d35e49aba79ba55079ff9abd3d46c5e0f678df52 on redhat-developer:master.

coveralls avatar Jan 20 '21 08:01 coveralls

Unfortunately, LSP4E doesn't yet support onTypeFormatting ( https://bugs.eclipse.org/bugs/show_bug.cgi?id=537154 ) so I'm not able to test it either at the moment...

mickaelistria avatar Jan 20 '21 08:01 mickaelistria

Closing as the original issue is closed and this is no longer worked on

gorkem avatar Jun 25 '23 00:06 gorkem