vscode-yaml icon indicating copy to clipboard operation
vscode-yaml copied to clipboard

Opening large yaml file locks vscode

Open Greg-Myers-SB opened this issue 1 year ago • 3 comments

Type: Performance Issue

Given a large yaml file over 50k lines. When I look at the file. Then VSCode stops responding for several minutes until it finally times out. I'd expect VSCode to be running the extension in a background, or otherwise give some indication it's processing, or otherwise remain responsive.

Extension version: 1.12.2 VS Code version: Code 1.78.1 (Universal) (6a995c4f4cc2ced6e3237749973982e751cb0bf9, 2023-05-04T09:57:42.343Z) OS version: Darwin arm64 22.4.0 Modes: Sandboxed: No

System Info
Item Value
CPUs Apple M1 Pro (10 x 24)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) 9, 7, 7
Memory (System) 32.00GB (4.27GB free)
Process Argv
Screen Reader no
VM 0%

Greg-Myers-SB avatar May 10 '23 15:05 Greg-Myers-SB

First of all I am sorry that you have to work with a YAML file with 50K lines 😄 Does setting the value of yaml.maxItemsComputed improve the situation? By default this number is 5000

gorkem avatar May 25 '23 21:05 gorkem

First of all I am sorry that you have to work with a YAML file with 50K lines 😄

Thankfully my reason for working on files these large are to evaluate how to delete them. I've heard databases are pretty good at holding data 😆

Does setting the value of yaml.maxItemsComputed improve the situation? By default this number is 5000

Yes so that does increase performance enough that it does not crash.

When I have not changed it from the default (Before): image Dropping it to 1000 made it so I could edit a 200k line YAML file (After): image

Greg-Myers-SB avatar May 26 '23 10:05 Greg-Myers-SB

Thanks for confirming where the problem was. I need to think a bit, if there is something more we can do to improve it.

gorkem avatar May 27 '23 16:05 gorkem