vscode-yaml icon indicating copy to clipboard operation
vscode-yaml copied to clipboard

Eclipse Theia incompatibility caused by vscode minimal version

Open ssbarnea opened this issue 3 years ago • 3 comments

While trying to make vscode-ansible extension be loaded by Eclipse Theia, I discovered that latest version of vscode-yaml listed on open-vsx.org store within theia is 0.17 and not 0.18. I suspect this is caused by listing some requirements incompatible with theia like engines.vscode.

With 0.17 what happens is that extension fails to instantiate with an error message like:

The language client requires VS Code version ^1.52.0 but received version 1.50.0

Bumping the required version to 1.52.0 is likely a mistake that prevents use under theia and instead we should only require 1.50.0. Still, I am not sure if this does not cause some problems with the language server itself.

Related links

  • https://github.com/eclipse-theia/theia-blueprint/issues/96
  • https://github.com/ansible-community/vscode-ansible/pull/112

ssbarnea avatar May 15 '21 16:05 ssbarnea

It is not mistake, it was requirements of [email protected] which we use to have latest LSP protocol feature, like opening file(JSON Schema). So we limited on lowest vscode version.

evidolob avatar May 17 '21 06:05 evidolob

As I understand it, ^1.52.0 equals the range of 1.52.0 up to but less then 2.0.0.

@evidolob is that what you are saying with

limited on lowest vscode version

joshuawilson avatar May 17 '21 12:05 joshuawilson

@joshuawilson yes, minimum supported vscode version is 1.52.0

evidolob avatar May 17 '21 12:05 evidolob