vscode-openshift-tools icon indicating copy to clipboard operation
vscode-openshift-tools copied to clipboard

Toolkit does not recognize `.devfile.yml` files

Open AgentK9 opened this issue 2 years ago • 4 comments

E.g. without the a in yaml.

AgentK9 avatar Aug 25 '23 12:08 AgentK9

Looks like the offending line is here: https://github.com/redhat-developer/vscode-openshift-tools/blob/9aa1bc44bb45c54155beaa713030ce18cc046c1d/src/util/workspace.ts#L130

However there could be other parts that my cursory examination did not find.

AgentK9 avatar Aug 25 '23 12:08 AgentK9

@datho7561 can you please look into this and we should update our use case based on the file extension.

mohitsuman avatar Aug 29 '23 18:08 mohitsuman

We don't detect devfile.yml or .devfile.yml, since odo don't detect those either.

datho7561 avatar Aug 29 '23 18:08 datho7561

Looks like the offending line is here:

https://github.com/redhat-developer/vscode-openshift-tools/blob/9aa1bc44bb45c54155beaa713030ce18cc046c1d/src/util/workspace.ts#L130

We should narrow the scope of the file watchers, since this will also match not-actually-a-devfile.yaml, which also isn't recognized by odo. I'll try to handle this aspect as a part of #3120

datho7561 avatar Aug 29 '23 18:08 datho7561