redhat-developer
Java Formatter settings are not used
If I open the flow-server project from https://github.com/vaadin/flow/tree/main/flow-server
and have Eclipse formatter settings set to use https://raw.githubusercontent.com/vaadin/flow/main/eclipse/VaadinJavaConventions.xml which defines <setting id="org.eclipse.jdt.core.formatter.tabulation.size" value="4"/>
then when I open e.g. the HandlerHelperTest.java file, VS Code shows "Spaces: 8" in the bottom bar and formatting the file changes it to use indentation of 8 spaces instead of 4
The settings file should be fine because when I go back to command line and run mvn formatter:format in the project, the indentation is changed back to 4 spaces.
Environment
- Operating System: macOs Ventura
- JDK version: 17
- Visual Studio Code version: 1.76.2
- Java extension version: 1.16.0
Steps To Reproduce
- See above
Current Result
File is not formatted according to given settings
Expected Result
File is formatted according to given settings
If I select "Ident Using Spaces", I see this
Why would the "current" tab size differ from the default?
Some files in the project show "Spaces: 8" and other files seem to use the default and show "Spaces: 4"
Why would the "current" tab size differ from the default?
The default tab size should be configured via VS Code setting editor.tabSize. As for the current tab size, you can check VS Code setting editor.detectIndentation, if it's set, VS Code will auto detect the indentation of your current file and show it.
Thanks! Now it works as expected when I turned of editor.detectIndentation.
But does it not kind of defeat the purpose of having formatter settings defined, if they are not used by default for incorrectly formatted files?
Agree. Currently as for indentation settings, vscode-java will pick VS Code ones rather than the specific settings in profile. That would be not suitable since most users want to specific indentation settings within a project via a profile, we should fix it.
