vscode-java icon indicating copy to clipboard operation
vscode-java copied to clipboard

[feature] Improve Move symbol by using Custom QuickPick which will not load all symbols.

Open gayanper opened this issue 3 years ago • 4 comments

Today the Move symbol refactor operation load all types in the project. If the project is large, it takes a lot of time to load the items and its overwhelming to select from.

A suggestion is to use https://code.visualstudio.com/api/references/vscode-api#QuickPick%3CT%3E so that we can start loading the types which are in the same package to start with, and then when user start typing we can use that as a query parameter and load more items with a de-bounce.

This will give much better user experience and fast response.

gayanper avatar Aug 16 '22 13:08 gayanper

@jdneo WDYT ?

gayanper avatar Aug 16 '22 13:08 gayanper

Do you mean use the API createQuickPick, which will have the full lifecycle control of the quick pick widget?

jdneo avatar Aug 17 '22 01:08 jdneo

Yes

gayanper avatar Aug 17 '22 04:08 gayanper

The idea looks good to me 👍.

Feel free to make contributions if you would like to :)

BTW, since the quickpick API is VS Code only widget, so from the APIs design aspect, please try to make it client-neutral -> to avoid breaking other client, and it possible for other clients to adopt this new capability.

jdneo avatar Aug 17 '22 04:08 jdneo